feat(core-editor): hot reload entity component from save#253
Open
feat(core-editor): hot reload entity component from save#253
Conversation
Tchips46
changed the title
github-actions
bot
added
packages:ecs-client
Exeloo
requested changes
Mar 26, 2026
Member
Exeloo
left a comment
Exeloo
left a comment
There was a problem hiding this comment.
You must add core editor to contribution tools (labels, labeler, issue templates)
Member
|
Also wouldn't be better to import and extends from base core features that doesn't change ? Like for class or functions that doesn't change use the core one and for class which changed, extends the core one to use old method that doesn't change |
Exeloo
requested changes
Mar 28, 2026
Exeloo
requested changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Resolves #231
How do you test this PR?